Skip to content

REF: avoid accessing private iloc methods #38337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2020
Merged

REF: avoid accessing private iloc methods #38337

merged 1 commit into from
Dec 7, 2020

Conversation

jbrockmendel
Copy link
Member

I'm pretty sure this is made possible by @phofl's recent fix to only call _align_series in _setitem_with_indexer when name != "iloc"

@phofl
Copy link
Member

phofl commented Dec 6, 2020

Nice!

@topper-123 topper-123 added Indexing Related to indexing on series/frames, not to indexes themselves Refactor Internal refactoring of code labels Dec 7, 2020
@topper-123 topper-123 added this to the 1.3 milestone Dec 7, 2020
@jreback jreback modified the milestones: 1.3, 1.2 Dec 7, 2020
@jreback jreback merged commit b8acfc4 into pandas-dev:master Dec 7, 2020
@jbrockmendel jbrockmendel deleted the ref-get_indexer-3 branch December 7, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Refactor Internal refactoring of code
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrockmendel @phofl @jreback @topper-123