Skip to content

REF: simplify casting of scalars to array #38313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 7, 2020
Merged

REF: simplify casting of scalars to array #38313

merged 4 commits into from
Dec 7, 2020

Conversation

jbrockmendel
Copy link
Member

cast_scalar_to_array is only used in two places, and in each of them there is a better option available.

jorisvandenbossche
jorisvandenbossche reviewed Dec 5, 2020
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jreback
Copy link
Contributor

jreback commented Dec 7, 2020

great, pls rebase and ping on green

@jreback jreback added Clean Dtype Conversions Unexpected or buggy dtype conversions labels Dec 7, 2020
@jreback jreback added this to the 1.2 milestone Dec 7, 2020
@jbrockmendel
Copy link
Member Author

ping

@jreback jreback merged commit 803bdd2 into pandas-dev:master Dec 7, 2020
@jbrockmendel jbrockmendel deleted the ref-cast_scalar_to_array branch December 7, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

Assignees
No one assigned
Labels
Clean Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @jorisvandenbossche