Skip to content

BUG: read_json does not respect chunksize #38293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 23, 2020
Merged

BUG: read_json does not respect chunksize #38293

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0b477a6
Fix #36791 and #34548 correctly respecting read_json chunksize.
robertwb Dec 4, 2020
76d2ce6
Test of read_json chunksize.
robertwb Dec 22, 2020
b3ea535
whatsnew entry
robertwb Dec 22, 2020
d8d5942
Merge branch 'master' into json-chunksize
robertwb Dec 22, 2020
fc21579
Make precommit happy.
robertwb Dec 22, 2020
4b856ee
Add reference to bug fixed in the test.
robertwb Dec 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/io/json/_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ def _preprocess_data(self, data):
If self.chunksize, we prepare the data for the `__next__` method.
Otherwise, we read it into memory for the `read` method.
"""
if hasattr(data, "read") and (not self.chunksize or not self.nrows):
if hasattr(data, "read") and not (self.chunksize or self.nrows):
data = data.read()
self.close()
if not hasattr(data, "read") and (self.chunksize or self.nrows):
Expand Down