-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: DataFrame.apply with axis=1 and EA dtype #38272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @jbrockmendel for the PR. The code sample in #36785 still fails, but now with but happy to close #36785 if we feel that the underlying issue is solved. |
can you add a release note to 1.1.5 in the regression fixes section |
looks like there maybe still an issue. |
ill take another look this afternoon |
thanks @jbrockmendel. code sample in OP is now passing. before the edit, the existing The sample in the OP was still failing and the dataframe had more than 1 column. Since only the one test was failing, it appears that this case is not covered by existing tests. maybe we should an additional test case to
|
obj = self.obj | ||
for i in range(len(obj)): | ||
yield obj._ixs(i, axis=0) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, obviously we want to sync these up in a followon
@meeseeksdev backport 1.1.x |
…8295) Co-authored-by: jbrockmendel <[email protected]>
@simonjayhawkins im falling behind on GH notifications. do i need to make a PR adding more tests or something here? |
The PR was merged so I assume not. |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff