Skip to content

CLN: remove relative imports #3827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2013
Merged

CLN: remove relative imports #3827

merged 1 commit into from
Jun 10, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 10, 2013

No description provided.

@hayd
Copy link
Contributor

hayd commented Jun 10, 2013

This fixed the (motivating) syntax error from #3821, and has the benefit of working on py3 (when not built is show ImportError rather than syntax error). Merge?

@cpcloud
Copy link
Member Author

cpcloud commented Jun 10, 2013

will rebase and then i willl merge

@cpcloud
Copy link
Member Author

cpcloud commented Jun 10, 2013

@jreback good 2 merge?

@jreback
Copy link
Contributor

jreback commented Jun 10, 2013

what exactly is the reason the relative imports are bad?

@cpcloud
Copy link
Member Author

cpcloud commented Jun 10, 2013

i don't think they are bad necessarily, but they're certainly not needed here since they were used to refer to pandas. see here for short pro/con discussion. also the exception being caught here was too general...whenever i have an installation issue it's hidden by a cryptic error message... about not being able to import hashtable

@hayd
Copy link
Contributor

hayd commented Jun 10, 2013

Your error message is a big improvement, (and solves the even less descriptive "syntax error" in py2.5+3).

@cpcloud
Copy link
Member Author

cpcloud commented Jun 10, 2013

also importerrors should not be caught by except Exception clauses they should be caught by except ImportError: let's call a spade a spade...

@jreback
Copy link
Contributor

jreback commented Jun 10, 2013

sounds good then

cpcloud added a commit that referenced this pull request Jun 10, 2013
@cpcloud cpcloud merged commit 3129fb3 into pandas-dev:master Jun 10, 2013
@cpcloud cpcloud deleted the remove-relative-imports branch June 10, 2013 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants