Skip to content

C408 rewrite dict call to dict literals #38263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 3, 2020
Merged

C408 rewrite dict call to dict literals #38263

merged 3 commits into from
Dec 3, 2020

Conversation

vmdhhh
Copy link
Contributor

@vmdhhh vmdhhh commented Dec 3, 2020 •
edited
Loading

  • xref CLN: C408 Unnecessary dict call - rewrite as a literal #38138
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
    Identify unnecessary dict call - rewrite as a literal in ./pandas/tests/io/pytables/test_store.py, ./pandas/core/arrays/interval.py

@vmdhhh
Copy link
Contributor Author

vmdhhh commented Dec 3, 2020

I am not sure how to assign someone for review.
@jreback Would you be able to review this?

@vmdhhh vmdhhh mentioned this pull request Dec 3, 2020
Closed
61 tasks
@jreback jreback added the Code Style Code style, linting, code_checks label Dec 3, 2020
@jreback jreback added this to the 1.2 milestone Dec 3, 2020
@jreback jreback merged commit b58880c into pandas-dev:master Dec 3, 2020
@jreback
Copy link
Contributor

jreback commented Dec 3, 2020

thanks @vmdhhh

you don't assign reviews, they will just happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@vmdhhh @jreback