-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
TST: mark all excel tests as slow #38258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a60b1e9
to
d1f4999
Compare
Do you have an overview of timings of the different tests? Are all of them slow, or only a subset? You mention the setup and teardown is slow, but are those needed for all tests, or can this be speed up? I think we should try to more targetted mark certain tests as slow, not entire subsets of functionality (eg we have tests for minimum versions of dependencies, which would now not be run anymore) |
I ran
So, not that these take a massive amount of time individually,
As @jreback mentioned, test run time is a concern. However, what I do not understand is how the purpose for the pipelines is selected. |
@ivanovmg I think its ok to move some of the excel tests to slow, but we have to be really careful because there are lots of variations that are tested, currently these are reflected in the .yaml files for the fast tests. so likely some of these variations are NOT running on the slow builds. |
I don't think this actually moves the needle either, the main culprit is this build: https://travis-ci.org/github/pandas-dev/pandas/jobs/747392896 is still taking an hour. |
All the excel tests have the same duration, so there is no opportunity to select those, which are slow in particular. |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
Marked all excel-related tests as slow.
There are a lot of time for setup and teardown for every test.
Overall, moving these tests to "slow" category may probably save about 5 minutes of test time for "not slow" pipelines.