TYP: handle mypy ignore in pandas/_testing #38236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's green, except failing |
jreback
requested changes
Dec 4, 2020
pandas/_testing.py
Outdated
| compress_method = get_lzma_file(lzma) | ||
| else: | ||
| raise ValueError(f"Unrecognized compression type: {compression}") | ||
| compress_method = _select_compress_method(compression) |
There was a problem hiding this comment.
i think you could leave this inline and just type compress_method no?
There was a problem hiding this comment.
I guess so.
I just thought that some small function extraction will be helpful here.
But if you suggest against the extraction, I can definitely do that way as well.
There was a problem hiding this comment.
I would prefer for this to stay inline as well
There was a problem hiding this comment.
I inlined the function and also slid the conditionals. Can revert if this is not what you expect, but in my opinion, it simplifies the understanding that zip has a different signature as compared to other compression methods.
jreback
approved these changes
Dec 19, 2020
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffHandle mypy ignore comments in
pandas/_testing.py, functionwrite_to_compressed.