-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
ENH: DataFrame.corr(method='spearman') is cythonized. #3823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ok....can you put a release notes mention? (enhancement section), and if you are gung ho, pls add...a vbench entry (vb_suite/stat_ops.py)....it could have a start date of say 2013/1/1 (or earlier if you can figure out about when spearman was added....was sometime last year, but I don't remember) |
@jreback is there any consensus about fused types/memoryviews? if there's a consensus to use should we "require" that new cython use it? |
should use them |
fused types sure but what about memoryviews here? |
if u can get them to work |
|
||
N, K = (<object> mat).shape | ||
|
||
if minp is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just make this default to 1 and then u can give it a type of Py_ssize_t
...
Yes, I will push the changes in the next day or two. |
@jniznan can you see if you can finish this up ? thanks |
@jniznan can u rebase? |
@cpcloud it should be rebased now. |
Merged...thanks.....nice improvements
|
It should be more than 10 times faster than the old version.