-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: context-manager for chunksize/iterator-reader #38225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this looks pretty neat. can you add a small note section in io.rst which shows this off. i think this is ok for 1.2, can add json/sas as followsup. |
I don't understand why the documentation example is failing: Exception in /home/runner/work/pandas/pandas/doc/source/user_guide/io.rst at block ending on line 1586 edit: the blank line was causing the issue, it was interpreted as the end of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great. just some minor doc omments. ping on green.
@jreback green. I hope the whatsnew entry is good now |
thanks @twoertwein very nice |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
Allows (and encourages) the following use:
Same can be done for
read_json/sas
(I think these are all methods that supportchunksize
). If this PR should make it into 1.2, I can quickly add the changes for json/sas as well.Are there more places to promote this new context manager?