Skip to content

Backport PR #38099: BUG: fix wrong error message in deprecated 2D indexing of Series with datetime values #38210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 1, 2020
Merged

Backport PR #38099: BUG: fix wrong error message in deprecated 2D indexing of Series with datetime values #38210

merged 3 commits into from
Dec 1, 2020

Conversation

jorisvandenbossche
Copy link
Member

Backport PR #38099 on branch 1.1.x

@jorisvandenbossche jorisvandenbossche added this to the 1.1.5 milestone Dec 1, 2020
@simonjayhawkins
Copy link
Member

@jorisvandenbossche the test failures are the same as master. was the change in e350b82 needed?

merge when ready.

@jorisvandenbossche
Copy link
Member Author

was the change in e350b82 needed?

Yeah, the __getitem__ behaviour of DatetimeArray has apparently quite changed on master, so it didn't work directly on 1.1.x. This does the conversion to a numpy array first, on the 1D EA, and only then does the 2D indexing operation. This seemed relatively safe to do

@simonjayhawkins simonjayhawkins merged commit b376fb9 into pandas-dev:1.1.x Dec 1, 2020
@simonjayhawkins
Copy link
Member

Thanks @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche deleted the backport-of-pr-38099-on-1.1.x branch December 1, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisvandenbossche @simonjayhawkins