BUG: Avoid duplicates in DatetimeIndex.intersection #38196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Dec 1, 2020
| @@ -687,7 +687,7 @@ def intersection(self, other, sort=False): | |||
| self._validate_sort_keyword(sort) | |||
| self._assert_can_do_setop(other) | |||
|
|
|||
| if self.equals(other): | |||
| if self.equals(other) and not self.has_duplicates: | |||
| return self._get_reconciled_name_object(other) | |||
There was a problem hiding this comment.
should we handle the self.equals(other) but non-unique case here? (like MultIIndex i think)
There was a problem hiding this comment.
Should be consistent. best would probably be to handle this here.
There was a problem hiding this comment.
Handled it here now, and called _convert_can_do_setop. Have seen you moved the remaining part to _intersection in #38190, so I will keep this here as it is now that we are consistent
jbrockmendel
reviewed
Dec 1, 2020
| pd.Timestamp("2019-12-12"), | ||
| ] | ||
| ) | ||
| result = idx1.intersection(idx1) |
There was a problem hiding this comment.
Hm good point. Parametrized the test
yah im pretty sure that test is wrong xref #38111 |
|
Fixed the test |
|
thanks @phofl very nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff@jbrockmendel I think we should call
_convert_can_do_setophere too, butpandas/pandas/tests/indexes/datetimes/test_setops.py
Line 472 in 56b9a80