Skip to content

Revert "REF: define nanargminmax without values_for_argsort" #38177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2020
Merged

Revert "REF: define nanargminmax without values_for_argsort" #38177

merged 1 commit into from
Nov 30, 2020

Conversation

jorisvandenbossche
Copy link
Member

Reverts #37815

@jorisvandenbossche jorisvandenbossche added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff ExtensionArray Extending pandas with custom dtypes or arrays. labels Nov 30, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.2 milestone Nov 30, 2020
@jorisvandenbossche
Copy link
Member Author

See discussion on the PR #37815, argmin/argmax on purpose didn't do a full argsort for performance reasons

@jorisvandenbossche
Copy link
Member Author

I will do a PR updating the docs / comments on expectations how EA authors should implement this in a follow-up

@jorisvandenbossche
Copy link
Member Author

Failure are the npdev failures present on master as well

@jorisvandenbossche jorisvandenbossche merged commit dda8c35 into master Nov 30, 2020
@jorisvandenbossche jorisvandenbossche deleted the revert-37815-ref-nanargminmax branch November 30, 2020 13:21
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Nov 30, 2020
@jorisvandenbossche @jbrockmendel
Revert "REF: define nanargminmax without values_for_argsort (pandas-d…
9734474 
…ev#37815)" (pandas-dev#38177)

This reverts commit 840c142.
This was referenced Dec 1, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
1 participant
@jorisvandenbossche