-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: support nanoseconds in Period constructor #38175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
91a7c7e
BUG #34621 added nanosecond support to class Period
73a6eab
BUG #34621 added tests
ea9f69c
BUG #34621 added tests (black pandas passed)
ab5640f
#34131 fix one test failure
95d740e
#34621 review taken into account
abb0936
#34621 review taken into account, and suppress a bad copy/paste on li…
8a559cb
#34621 Added nanosecond support to Period constructor
2b2f1d0
merge with master
arw2019 63e72d8
rewrite test
arw2019 e511df3
merge master
arw2019 55cf0ac
whatsnew
arw2019 737ce75
merge conflict
arw2019 9a41f1a
Merge branch 'master' of https://github.com/pandas-dev/pandas into GH…
arw2019 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't we effectively doing the parsing twice, this way? (once in
parse_time_string
, once inTimestamp
) Any way to avoid this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - @jreback suggested integrating this a bit more into
parse_time_string
I opened #38312 to track resolution (I'll have a go at it if no one else does)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!