BUG: array-like quantile fails on column groupby #38173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
lgtm. @TomAugspurger @jbrockmendel if you have a moment to review
jbrockmendel
reviewed
Dec 2, 2020
pandas/core/groupby/groupby.py
Outdated
| ) | ||
| .T.flatten() | ||
| ) | ||
| return result.take(indices, axis=1) |
There was a problem hiding this comment.
could a lot of this be shared with the axis=0 version by replacing result.columns with result.axes[1] and above replacing result.index with result.axes[0]? (which in both cases would then become result.axes[axis])
There was a problem hiding this comment.
sounds good, I will change this.
jbrockmendel
reviewed
Dec 2, 2020
doc/source/whatsnew/v1.2.0.rst
Outdated
| @@ -734,6 +734,7 @@ Groupby/resample/rolling | |||
| - Bug in :meth:`DataFrame.groupby` dropped ``nan`` groups from result with ``dropna=False`` when grouping over a single column (:issue:`35646`, :issue:`35542`) | |||
| - Bug in :meth:`.DataFrameGroupBy.head`, :meth:`.DataFrameGroupBy.tail`, :meth:`SeriesGroupBy.head`, and :meth:`SeriesGroupBy.tail` would raise when used with ``axis=1`` (:issue:`9772`) | |||
| - Bug in :meth:`.DataFrameGroupBy.transform` would raise when used with ``axis=1`` and a transformation kernel (e.g. "shift") (:issue:`36308`) | |||
| - Bug in :meth:`.DataFrameGroupBy.quantile` couldn't handle with arraylike ``q`` when grouping by columns (:issue:`35269`) | |||
|
thanks @GYHHAHA very nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff