Skip to content

TST: add comment that plotting tests are slow #38171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

ivanovmg
Copy link
Member

Add comment (module docstring) in pandas/tests/plotting/common.py,
mentioning that all plotting tests are marked as slow.

@ivanovmg ivanovmg requested a review from jreback November 30, 2020 04:12
"""
Module consolidating common testing functions for checking plotting.

Currently all plotting tests are marked as slow.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add via the pytest.mark.slow at the module level

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Done.

@jreback jreback added Docs Testing pandas testing functions or related to the test suite labels Nov 30, 2020
@ivanovmg ivanovmg requested a review from jreback December 1, 2020 18:11
@jreback jreback added this to the 1.2 milestone Dec 2, 2020
@jreback jreback merged commit 0e52dbe into pandas-dev:master Dec 2, 2020
@jreback
Copy link
Contributor

jreback commented Dec 2, 2020

thanks @ivanovmg

@ivanovmg ivanovmg deleted the test_plotting_slow_comment branch December 3, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants