BUG: Series.at returning Series with one element instead of scalar #38101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
the
Indexing
jreback
requested changes
Nov 26, 2020
pandas/tests/indexing/test_scalar.py
Outdated
| @@ -300,3 +300,10 @@ def test_multiindex_at_set(): | |||
| assert series.at[1, 3] == 5 | |||
| series.loc[1, 3] = 6 | |||
| assert series.loc[1, 3] == 6 | |||
|
|
|||
|
|
|||
| def test_at_get_multiindex_one_level(): | |||
There was a problem hiding this comment.
can you rename to
test_multiindex_at_get_one_level
do we have similar tests? can you co-locate
There was a problem hiding this comment.
In the same file above and test_at. One in test_partial, but this one is checking different things
Renamed the test
|
hmm, lots of things are failing, can you merge master and ping on green. |
|
Good test, caught a bug. Adjusted the code. |
jreback
approved these changes
Nov 28, 2020
|
@jreback green now |
|
thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffI think if we are at this place and len(values) is 1, we want to return a scalar instead of a Series. This happens only because loc is a slice (0,1) with one MultiIndex level instead of a scalar.
Should I create a file to move all MultiIndex at tests to the MultiIndex folder?