CLN: inconsistent namespace usage in tests.indexes

[jbrockmendel]

Finding these annoying while doing other work in this directory.

[jreback]

can u update the precommit rule

[jbrockmendel]

can u update the precommit rule

short answer: not really. this only gets a handful of things in a handful of files.

i pinged @MarcoGorelli on the script; there are things I think it should catch that it isn't. i dont want to tinker with the script until im confident it is working correctly.

[MarcoGorelli]

The original script only looks for class names - for methods, I think we could change [A-Z] to \w - I can test it out later

i pinged @MarcoGorelli on the script

Where did you ping me? If it was in another issue then I may have missed it, sorry

[jbrockmendel]

Where did you ping me? If it was in another issue then I may have missed it, sorry

Huh I'm not finding it, my bad. I was asking why CLASS_NAMES had been removed, since ive noticed that both MultiIndex and pd.MultiIndex are present in some of the indexes test files.

[MarcoGorelli]

It might be that they appear if they're present with starting brackets, currently we just check for cases of e.g. MultiIndex( and pd.MultiIndex( being in the same file. pandas/tests/indexes/test_common.py contains pd.MultiIndex and MultiIndex, but neither are called, they're just used in isinstance checks.

Maybe it's OK to remove the paren and extend the check beyond classes now

[jbrockmendel]

Makes sense. For now I'll be happy with just fixing the handful in this PR so I don't keep stumbling over them in other branches.

[MarcoGorelli]

sure - I've opened #38093 as a placeholder

[jreback]

sure - I've opened #38093 as a placeholder

great yeah we ought to become strict on these