-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: pytables in py39 #38041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: pytables in py39 #38041
Conversation
@@ -4462,7 +4462,7 @@ def test_categorical(self, setup_path): | |||
|
|||
# Appending must have the same categories | |||
df3 = df.copy() | |||
df3["s"].cat.remove_unused_categories(inplace=True) | |||
df3["s"] = df3["s"].cat.remove_unused_categories() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated, just getting rid of a FutureWarning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
can you add pytables to the 3.9 build (I guess its built now?) https://github.com/pandas-dev/pandas/blob/master/ci/deps/azure-39.yaml |
it doesnt have a wheel, so i think the build would take too long |
it needs to be installed via conda forge i am sure it's there |
sounds good, just pushed |
i think that worked, great. There is an issue to add more deps to this build let me bump it. |
I guess should put a release note? |
for 1.1.x? |
hmm yeah while you are at it, can you add scipy and pyarrow==1.0 (though not sure they support 3.9 with that version) |
scipy/pyarrow added and green |
This comment has been minimized.
This comment has been minimized.
* BUG: pytables in py39 * add pytables to py39 ci * whatsnew 1.1.5 * scipy and pyarrow to py39 build
Co-authored-by: jbrockmendel <[email protected]>
There are failures I'm getting locally since homebrew bumped up to py39. I'm not seeing them on the CI, but they did appear around the same time as these different unexplained pytables failures started showing up.