TST/REF: collect Index.equals tests #38011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Nov 23, 2020
| Tests shared for DatetimeIndex/TimedeltaIndex/PeriodIndex | ||
| """ | ||
| from datetime import datetime, timedelta | ||
|
|
There was a problem hiding this comment.
should these be in pandas/tests/indexes/datetimelike/test_equals (or as appropriate)?
There was a problem hiding this comment.
havent decided. im split between implementing tests/indexes/{index_type}/methods/ vs tests/indexes/methods/ for things like equals, leaning towards the latter.
There was a problem hiding this comment.
yeah doing this for other types, so i think it makes sense here
There was a problem hiding this comment.
do you mind holding off on that move while i get a little closer to getting everything collected
There was a problem hiding this comment.
kk, ok for merge here, but really think this is inconcsistent
jreback
added
Indexing
jreback
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.