CLN: avoid try/except in Index methods #37990
Conversation
| if dropna and not isinstance(self, ABCMultiIndex): | ||
| # isna not defined for MultiIndex |
There was a problem hiding this comment.
It is reasonable to consider that ABCMultiIndex is never going to have isna defined?
There was a problem hiding this comment.
This came up on a dev call earlier this year and it didn't sound like there was reason for optimism.
There was a problem hiding this comment.
isna is tricky because a MI can be multi-valued e.g does isna refer to any value on a level, or all levels be null? it would be reasonable to actually return a multi-value here (e.g. same shape as the MI), but would need to see the implications if this is done.
| if dropna and not isinstance(self, ABCMultiIndex): | ||
| # isna not defined for MultiIndex |
There was a problem hiding this comment.
isna is tricky because a MI can be multi-valued e.g does isna refer to any value on a level, or all levels be null? it would be reasonable to actually return a multi-value here (e.g. same shape as the MI), but would need to see the implications if this is done.
| @@ -313,23 +308,23 @@ def max(self, axis=None, skipna=True, *args, **kwargs): | |||
| return self._na_value | |||
|
|
|||
| i8 = self.asi8 | |||
| try: | |||
|
|
|||
| if len(i8) and self.is_monotonic: | |||
There was a problem hiding this comment.
prob can de-duplicate this with min
jreback
added
Clean
Indexing
No description provided.