TST: add test to verify column does not lose categorical type when using loc #37988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgebhart
changed the title
jreback
requested changes
Nov 21, 2020
jreback
added
Categorical
|
failed test is unrelated to my changes - do you collect flaky tests somewhere? i.e. |
fgebhart
force-pushed
the
column_loses_category
branch
from
5f16e01 to
353bce1
Compare
jreback
reviewed
Nov 23, 2020
pandas/tests/indexing/test_loc.py
Outdated
| @@ -1285,6 +1286,14 @@ def test_loc_setitem_datetime_keys_cast(self): | |||
| expected = DataFrame({"one": [100.0, 200.0]}, index=[dt1, dt2]) | |||
| tm.assert_frame_equal(df, expected) | |||
|
|
|||
| def test_loc_setitem_categorical_column_retains_dtype(self): | |||
There was a problem hiding this comment.
can you add the ordered fixture (just include it in the arg list and pass to Categorical), it should just work. ping on green.
jbrockmendel
approved these changes
Nov 23, 2020
jreback
approved these changes
Nov 23, 2020
|
thanks @fgebhart very nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAdded a test to verify the behavior described in issue #16360. However, I'm not 100% sure about the location of the test.