TST: add messages to bare pytest raises in pandas/tests/io/pytables/test_timezones.py #37975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 19, 2020 11:59
…ytest-raises-timezones
marktgraham
changed the title
MarcoGorelli
approved these changes
Nov 20, 2020
MarcoGorelli
suggested changes
Nov 20, 2020
There was a problem hiding this comment.
It looks like, during one of the CI jobs, the error shows 'existing_value [dateutil/US/Eastern] conflicts with new value [dateutil/EET]', without /usr/share/zoneinfo
so you may need a regular expression here, e.g. something like
msg = (
r"invalid info for \[values_block_1\] for \[tz\], "
r"existing_value \[dateutil/.*US/Eastern\] "
r"conflicts with new value \[dateutil/.*EET\]"
)
Thanks!
Will do, I think that will work for a couple of the other files. |
|
@MarcoGorelli thanks for your suggestion, I made the change and now all the checks pass. |
MarcoGorelli
approved these changes
Nov 20, 2020
jreback
added
Testing
|
thanks @marktgraham |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis PR adds messages to the bare pytest raises in pandas/tests/io/pytables/test_timezones.py. This PR references #30999.