Skip to content

BLD: set inplace in setup.cfg #37973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@ RUN conda env update -n base -f "$pandas_home/environment.yml"

# Build C extensions and pandas
RUN cd "$pandas_home" \
&& python setup.py build_ext --inplace -j 4 \
&& python setup.py build_ext -j 4 \
&& python -m pip install -e .
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ clean_pyc:
-find . -name '*.py[co]' -exec rm {} \;

build: clean_pyc
python setup.py build_ext --inplace
python setup.py build_ext

lint-diff:
git diff upstream/master --name-only -- "*.py" | xargs flake8
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
. ~/virtualenvs/pandas-dev/bin/activate && \
python -m pip install --no-deps -U pip wheel setuptools && \
pip install cython numpy python-dateutil pytz pytest pytest-xdist hypothesis pytest-azurepipelines && \
python setup.py build_ext -q -i -j2 && \
python setup.py build_ext -q -j2 && \
python -m pip install --no-build-isolation -e . && \
pytest -m 'not slow and not network and not clipboard' pandas --junitxml=test-data.xml"
displayName: 'Run 32-bit manylinux2014 Docker Build / Tests'
Expand Down
2 changes: 1 addition & 1 deletion ci/azure/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- bash: |
source activate pandas-dev
conda list
python setup.py build_ext -q -i -j 4
python setup.py build_ext -q -j 4
python -m pip install --no-build-isolation -e .
displayName: 'Build'

Expand Down
2 changes: 1 addition & 1 deletion ci/setup_env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ conda list pandas
# Make sure any error below is reported as such

echo "[Build extensions]"
python setup.py build_ext -q -i -j2
python setup.py build_ext -q -j2

echo "[Updating pip]"
python -m pip install --no-deps -U pip wheel setuptools
Expand Down
10 changes: 5 additions & 5 deletions doc/source/development/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ See https://www.jetbrains.com/help/pycharm/docker.html for details.

Note that you might need to rebuild the C extensions if/when you merge with upstream/master using::

python setup.py build_ext --inplace -j 4
python setup.py build_ext -j 4

.. _contributing.dev_c:

Expand Down Expand Up @@ -268,7 +268,7 @@ We'll now kick off a three-step process:
source activate pandas-dev

# Build and install pandas
python setup.py build_ext --inplace -j 4
python setup.py build_ext -j 4
python -m pip install -e . --no-build-isolation --no-use-pep517

At this point you should be able to import pandas from your locally built version::
Expand Down Expand Up @@ -315,7 +315,7 @@ You'll need to have at least Python 3.6.1 installed on your system.
python -m pip install -r requirements-dev.txt

# Build and install pandas
python setup.py build_ext --inplace -j 4
python setup.py build_ext -j 4
python -m pip install -e . --no-build-isolation --no-use-pep517

**Unix**/**macOS with pyenv**
Expand All @@ -339,7 +339,7 @@ Consult the docs for setting up pyenv `here <https://github.com/pyenv/pyenv>`__.
python -m pip install -r requirements-dev.txt

# Build and install pandas
python setup.py build_ext --inplace -j 4
python setup.py build_ext -j 4
python -m pip install -e . --no-build-isolation --no-use-pep517

**Windows**
Expand All @@ -365,7 +365,7 @@ should already exist.
python -m pip install -r requirements-dev.txt

# Build and install pandas
python setup.py build_ext --inplace -j 4
python setup.py build_ext -j 4
python -m pip install -e . --no-build-isolation --no-use-pep517

Creating a branch
Expand Down
2 changes: 1 addition & 1 deletion pandas/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
raise ImportError(
f"C extension: {module} not built. If you want to import "
"pandas from the source directory, you may need to run "
"'python setup.py build_ext --inplace --force' to build the C extensions first."
"'python setup.py build_ext --force' to build the C extensions first."
) from e

from pandas._config import (
Expand Down
3 changes: 3 additions & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@

[build_ext]
inplace = 1

# See the docstring in versioneer.py for instructions. Note that you must
# re-run 'versioneer.py setup' after changing this section, and commit the
# resulting files.
Expand Down