Skip to content

TST: add nullable array frame constructor dtype tests #37972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2020
Merged

TST: add nullable array frame constructor dtype tests #37972

merged 2 commits into from
Nov 21, 2020

Conversation

arw2019
Copy link
Member

@arw2019 arw2019 commented Nov 20, 2020

@arw2019 arw2019 changed the title TST: add nullable array constructor dtype tests TST: add nullable array frame constructor dtype tests Nov 20, 2020
@arw2019 arw2019 self-assigned this Nov 20, 2020
@arw2019 arw2019 added Constructors Series/DataFrame/Index/pd.array Constructors Dtype Conversions Unexpected or buggy dtype conversions ExtensionArray Extending pandas with custom dtypes or arrays. labels Nov 20, 2020
@arw2019 arw2019 closed this Nov 20, 2020
@arw2019 arw2019 reopened this Nov 20, 2020
jreback
jreback reviewed Nov 20, 2020
View reviewed changes
pandas/tests/frame/test_constructors.py
@pytest.mark.parametrize(
"data,input_dtype,expected_dtype",
(
([True, False, None], "boolean", pd.BooleanDtype),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add string here as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jreback jreback added this to the 1.2 milestone Nov 20, 2020
@arw2019 arw2019 closed this Nov 21, 2020
@arw2019 arw2019 reopened this Nov 21, 2020
@jreback jreback merged commit 6454943 into pandas-dev:master Nov 21, 2020
@jreback
Copy link
Contributor

jreback commented Nov 21, 2020

thanks @arw2019

@arw2019 arw2019 deleted the GH28424 branch November 21, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees

@arw2019 arw2019

Labels
Constructors Series/DataFrame/Index/pd.array Constructors Dtype Conversions Unexpected or buggy dtype conversions ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

ExtensionArray being checked if is instance of collections.abc.Sequence
2 participants
@arw2019 @jreback