BUG: Bug in setitem raising ValueError when setting more than one column via array #37964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Regression
|
does this address the perf complaint in the OP from the linked issue? |
|
small comments, LGTM |
|
No, only the regression raising an error. |
|
LGTM cc @jreback (travis failure is unrelated) |
|
thanks @phofl |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffDid not add whatsnew, cause works on 1.1.4
Array to set has to have more or less rows than columns, otherwise bug won't occur. Wrong values would be set silently here.
This is only a regression on master, not related to any release
cc @jbrockmendel