Skip to content

CLN: More tests/window/* #37959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 19, 2020
Merged

CLN: More tests/window/* #37959

merged 4 commits into from
Nov 19, 2020

Conversation

mroeschke
Copy link
Member

  • Utilize more frame_or_series fixtures
  • Cleaned conftest.py
  • Moved some tests to the appropriate location
  • Reorg test_groupby into TestRolling and TestExpanding classes

@mroeschke mroeschke added Clean Window rolling, ewma, expanding labels Nov 19, 2020
@mroeschke mroeschke added this to the 1.2 milestone Nov 19, 2020
jreback
jreback approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, merge on green.

@mroeschke mroeschke merged commit 73a5213 into pandas-dev:master Nov 19, 2020
@mroeschke mroeschke deleted the clean/more_window_tests branch November 19, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean Window rolling, ewma, expanding
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @jreback