Skip to content

CLN: test_moments_expanding_consistency.py #37944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 18, 2020
Merged

CLN: test_moments_expanding_consistency.py #37944

merged 7 commits into from
Nov 18, 2020

Conversation

mroeschke
Copy link
Member

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Breaking up the predefined moments_consistency_* functions into more scoped tests with more pytest idioms.

@mroeschke mroeschke added Clean Window rolling, ewma, expanding labels Nov 18, 2020
@mroeschke mroeschke added this to the 1.2 milestone Nov 18, 2020
jreback
jreback approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm merge on green

@mroeschke mroeschke merged commit a022d7b into pandas-dev:master Nov 18, 2020
@mroeschke mroeschke deleted the cln/moments_expanding_consistency branch November 18, 2020 20:07
This was referenced Nov 18, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean Window rolling, ewma, expanding
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @jreback