Skip to content

CI: fix mypy error #37913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins added CI Continuous Integration Typing type annotations, mypy/pyright type checking labels Nov 17, 2020
@jbrockmendel
Copy link
Member

Neat, LGTM pending green

@simonjayhawkins
Copy link
Member Author

both #37898 and #37872 we independently Green.

The only downside here is that Index is part of the public API, so using Generic here means that the backing array becomes part of the public type interface and we may want to hide this as an implementation detail.

I think that I'll open another PR that justs ignores the error for now while we give this more thought.

@simonjayhawkins
Copy link
Member Author

I'll close this, while we still have np.ndarray resolving to Any which masks errors, since it's not just Index._values but also getitem still needs to be overloaded for the slice and use a typevar as a followon to #37898, so should do that first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants