Skip to content

DOC: add two new examples to the transform docs #37912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

marktgraham
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

This PR adds two examples to the transform user guide. The examples apply the transform method to a groupby object. This is from the PyData Global sprint, from this issue. The examples are taken from here and here.

@MarcoGorelli MarcoGorelli self-requested a review November 17, 2020 17:20
@marktgraham
Copy link
Contributor Author

Here is a preview of the new examples:
Screen Shot 2020-11-17 at 17 20 15
Screen Shot 2020-11-17 at 17 20 24

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, there are some pre commit errors, can you merge master and ping on green

@@ -324,4 +324,57 @@
0 0.000000 1.000000
1 1.000000 2.718282
2 1.414214 7.389056

It is possible to call transform on a GroupBy object:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can call transform on a GroupBy object.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the change.

@marktgraham marktgraham force-pushed the add-examples-to-transform-docs branch from 4a52b9b to 5c96a68 Compare November 19, 2020 11:14
@marktgraham
Copy link
Contributor Author

marktgraham commented Nov 19, 2020

@jreback I have merged with master and now all checks pass.

@jreback jreback added this to the 1.2 milestone Nov 19, 2020
@jreback jreback merged commit 6ab69e0 into pandas-dev:master Nov 19, 2020
@jreback
Copy link
Contributor

jreback commented Nov 19, 2020

thanks @marktgraham

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants