BUG: Prevent Series.isin from unwantedly casting isin values from float to integer (GH21804) #37861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at to integer (GH21804)
|
Ran some perf benchmarks for tests that were troublesome last time (#21893): Will run entire test suite once we agree on the imp, since the run takes quite some time. |
jreback
requested changes
Nov 15, 2020
| if is_numeric_dtype(dtype): | ||
| # Try downcasting values if comps is numeric to prevent precision | ||
| # loss resulting from casting values to comps its exact dtype | ||
| try: |
There was a problem hiding this comment.
this is what ensure_data does, and we really don't want to use try/excepts in this routine, everything should be via is_*
jreback
added
Dtype Conversions
|
note that this is duplicating: #37770 (though that has issues as well) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff