-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
namespace consistency for test_dtype.py #37843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you drop the first commit? So
then, in the interactive window, change the first
Then,
Let me know if anything trips you up here |
@@ -133,7 +133,7 @@ def test_compare_scalar_na(self, op, array, nulls_fixture, request): | |||
result = op(array, nulls_fixture) | |||
expected = self.elementwise_comparison(op, array, nulls_fixture) | |||
|
|||
if nulls_fixture is pd.NA and array.dtype != pd.IntervalDtype("int64"): | |||
if nulls_fixture is pd.NA and array.dtype != IntervalDtype("int64"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you revert this change? Only pd.Interval
needed changing, not pd.IntervalDtype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good now, thanks!
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff