Skip to content

Fix cases of inconsistent namespacing in tests #37842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2020
Merged

Fix cases of inconsistent namespacing in tests #37842

merged 1 commit into from
Nov 15, 2020

Conversation

jan-mue
Copy link
Contributor

@jan-mue jan-mue commented Nov 14, 2020

Additional fixes for MarcoGorelli/PyDataGlobal2020-sprint#1.
Continues the work of lpkirwin in #37838.

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@alimcmaster1 alimcmaster1 added the Testing pandas testing functions or related to the test suite label Nov 14, 2020
@alimcmaster1 alimcmaster1 added this to the 1.2 milestone Nov 14, 2020
@MarcoGorelli MarcoGorelli added Code Style Code style, linting, code_checks and removed Testing pandas testing functions or related to the test suite labels Nov 15, 2020
@@ -3,18 +3,18 @@
"""
import pandas._config.config as cf

import pandas as pd
from pandas import CategoricalIndex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is because "CategoricalIndex" appears in some strings already

@MarcoGorelli
Copy link
Member

Thanks @jan-mue !

@MarcoGorelli MarcoGorelli merged commit a8918ae into pandas-dev:master Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants