CLN: remove unnecessary close calls and add a few necessary ones #37837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Nov 14, 2020
|
small comment, ping on green. |
jreback
approved these changes
Nov 14, 2020
|
thanks @twoertwein |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffFollow up to #37639. Close file handles as early as possible.
Remove
closecalls that are already within a try-except/finally block that closes the file handles.Add
closecall forread_jsonwhen we read the entire content in one go.Add close call in
read_csvwhen reaching the end of the iterator.Put
to/read_excelin a try-finally block to make sure that file handles are closed even in case of an exception.