-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Allow custom error values in parse_dates argument of read_sql like functions (GH35185) #37823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
33bdac6
BUG: Allow custom error values in parse_dates argument of read_sql (G…
avinashpancham bfdc016
Ignore call overload for one time exception
avinashpancham ff90c17
Merge remote-tracking branch 'upstream/master' into GH35185
avinashpancham e451c0e
Add tests for custom dateparsing error for read_sql
avinashpancham a7637d7
Generalize test for all sql read functions
avinashpancham 7d8a5b0
Add conditional mode for tests
avinashpancham c2b4b2e
Merge remote-tracking branch 'upstream/master' into GH35185
avinashpancham 1d3d25a
Typo
avinashpancham c4597b6
Updated test
avinashpancham 2054360
Merge remote-tracking branch 'upstream/master' into GH35185
avinashpancham 7673ed8
Update to_datetime call in _handle_date_column
avinashpancham 03d05d7
Merge remote-tracking branch 'upstream/master' into GH35185
avinashpancham ada00a1
Merge remote-tracking branch 'upstream/master' into GH35185
avinashpancham 42fd388
Move whatsnew message to v1.3.0
avinashpancham 99d4bb1
Update test
avinashpancham 0077f6b
Explicit cast to int64
avinashpancham ddcf646
Remove accidental check_dtype=False
avinashpancham a2b6635
Merge branch 'master' into GH35185
jreback 37af90a
Merge remote-tracking branch 'upstream/master' into GH35185
avinashpancham 664e97a
Fix wrong reference in whatsnew
avinashpancham 29a7c26
Add hyphen
avinashpancham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make this tests assert the results, otherwise its not actually testing anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done