Skip to content

DOC: capitalize Python as proper noun #37808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 14, 2020

Conversation

erictleung
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@MarcoGorelli
Copy link
Member

Thanks - can you also fix this in other doc pages, such as doc/source/ecosystem.rst and doc/source/user_guide/cookbook.rst? There's a few other places where it appears uncapitalised

@jreback jreback added the Docs label Nov 13, 2020
@jreback jreback added this to the 1.2 milestone Nov 13, 2020
pandas is Python 3 only now, so cautionary note is unnecessary.
@erictleung
Copy link
Contributor Author

Thanks - can you also fix this in other doc pages, such as doc/source/ecosystem.rst and doc/source/user_guide/cookbook.rst? There's a few other places where it appears uncapitalised

@MarcoGorelli sure thing! I ran:

grep python -r *
grep jupyter -r *

in the doc/source/ directory to find instances and changed them. I also found some other random capitalizations along the way.

I didn't touch anything in the whatsnew/ directory.

@erictleung
Copy link
Contributor Author

@MarcoGorelli hopefully got them now! Thanks for the suggestions. (Side note, just realized I can't spell my branches right and caused me some confusion while making edits 😅)

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks!

@jreback jreback merged commit 5844197 into pandas-dev:master Nov 14, 2020
@jreback
Copy link
Contributor

jreback commented Nov 14, 2020

thanks @erictleung

@erictleung erictleung deleted the fix-python-capitlization branch November 14, 2020 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants