Skip to content

BUG: skip_blank_lines ignored by read_fwf #37803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 14, 2020
Merged

BUG: skip_blank_lines ignored by read_fwf #37803

merged 6 commits into from
Nov 14, 2020

Conversation

ma3da
Copy link
Contributor

@ma3da ma3da commented Nov 13, 2020

ma3da added 4 commits November 13, 2020 00:41
@ma3da
BUG: skip_blank_lines ignored by read_fwf
f0c52a3 
GH37758
overriding PythonParser._remove_empty_lines in FixedWidthFieldParser
as empty line description differs
@ma3da
BUG: skip_blank_lines ignored by read_fwf
b27484e 
added a test
@ma3da
BUG: skip_blank_lines ignored by read_fwf
73984ac 
whatsnew notice
@ma3da
replaced filter usage
dc895d5
@ma3da ma3da marked this pull request as ready for review November 13, 2020 09:52
@jreback jreback added Bug IO CSV read_csv, to_csv labels Nov 14, 2020
@jreback jreback added this to the 1.2 milestone Nov 14, 2020
jreback
jreback approved these changes Nov 14, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @gfyoung if any comments, pls merge when ready.

gfyoung
gfyoung approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@gfyoung gfyoung merged commit 3ca6330 into pandas-dev:master Nov 14, 2020
@ma3da ma3da deleted the GH_37758 branch November 14, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@gfyoung gfyoung gfyoung approved these changes

Assignees
No one assigned
Labels
Bug IO CSV read_csv, to_csv
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

BUG: read_fwf() does not obey skip_blank_lines
3 participants
@ma3da @jreback @gfyoung