Skip to content

DOC: document the pitfalls of different byte orders #3780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2013
Merged

DOC: document the pitfalls of different byte orders #3780

merged 1 commit into from
Jun 6, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 6, 2013

closes #3778 .

@jreback
Copy link
Contributor

jreback commented Jun 6, 2013

fast!

@cpcloud
Copy link
Member Author

cpcloud commented Jun 6, 2013

Really digging hub and I've been using shortcut foo. Still need to check out typing of the dead...

@cpcloud
Copy link
Member Author

cpcloud commented Jun 6, 2013

@jreback i think this is good 2 go. now that i have push rights, is there anything to know about merging (other than git), conventions, etc.? i'm going to defer merging with master to you for the time being (i think that is wise since u've been doing it for a while) i think a practice run on something like this is good...do u use the gh interface? or do u do it thru cmd line? i'm comfortable either way, just wanted to see how u do it...

@jreback
Copy link
Contributor

jreback commented Jun 6, 2013

I generally use the merge button....however there are times when I merge on the command line
which allows you to edit if needed

I also do PRs for almost everything, once in a while I will push directly to master....just have to be careful not to break things (so e.g. if its only a doc change then no biggie)

just be careful and take time

other thing is you can now edit issues, assign labels and close issues.....

I generally am pretty cautious about closing, I ttry to give people a little time to responsd and close themselves

assign labels is pretty striaghtforward

try to assign labels (and milestones) to things with no milestones

on my own PR's I try to to have someone else take a look before mergine...esp if its something new....

go ahead and click the merge button here...!

@jreback
Copy link
Contributor

jreback commented Jun 6, 2013

also...I try to prod people to do test cases and add release notes/docs but sometimes just easier to do it
(that's when I would do a command line), to preserve their ownership of things....

@cpcloud
Copy link
Member Author

cpcloud commented Jun 6, 2013

cool thanks. maybe i will go on a milestone/issue labeling "binge" (where i'm sure of it) after making some more progress with eval...

cpcloud added a commit that referenced this pull request Jun 6, 2013
DOC: document the pitfalls of different byte orders
@cpcloud cpcloud merged commit 9bf78b8 into pandas-dev:master Jun 6, 2013
@cpcloud
Copy link
Member Author

cpcloud commented Jun 6, 2013

sweet i like the confirm

@cpcloud cpcloud deleted the doc-the-endian-stuff branch June 6, 2013 19:02
@jreback
Copy link
Contributor

jreback commented Jun 6, 2013

great....it also auto-closes the mentioned issue (if you put closes issue number in the issue description)

there is also a build on travis for pandas fyi.....click on the green button in the readme (on the code tab)

@jreback
Copy link
Contributor

jreback commented Jun 6, 2013

bingeing....purging.....

what I think we need is to sort thru some 0.12 issues and rate flag some for priority
(as well as remaining no milestone issues)

e.g. prio-high,med,low (prob wouldn't flag everything though)

@cpcloud
Copy link
Member Author

cpcloud commented Jun 6, 2013

yeah the travis build link is cool. i have a travis chrome extension that tries to put those tags on everything on gh. kinda neat.

@jreback
Copy link
Contributor

jreback commented Jun 6, 2013

coool....fyi....if you are looking for something to do :)

I think sql module needs some tlc....mainly to do proper type conversion (and I think there are a couple of open issues about it, see labels for data i/o), e.g. doesn't handle NaT properly...etc

@cpcloud
Copy link
Member Author

cpcloud commented Jun 6, 2013

actually right now i'm trying to repro #3763; sql-related actually, will check out the stuff you've mentioned. i wish there were personal task lists on gh sigh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame fails late when initialized from structured array with non-native byte order
2 participants