Remove unnecessary casts in tokenizer.c #37792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
commented
Nov 12, 2020
pandas/_libs/src/parser/tokenizer.c
Outdated
| } | ||
| } else { | ||
| *error = -1; | ||
| if (q != NULL) { | ||
| // p and pc are different len due to tsep removal. Can't report | ||
| // how much it has consumed of p. Just rewind to beginning. | ||
| *q = (char *)p; | ||
| *q = (char *)p; // TODO: this could be undefined behavior |
There was a problem hiding this comment.
We probably just need better types here. I don't think q is ever actually mutated, but if it is this would be undefined behavior as the contents of p are qualified as const
jreback
requested changes
Nov 13, 2020
| @@ -600,7 +599,7 @@ static int parser_buffer_bytes(parser_t *self, size_t nbytes) { | |||
| TRACE(("PUSH_CHAR: ERROR!!! slen(%d) >= stream_cap(%d)\n", slen, \ | |||
| self->stream_cap)) \ | |||
| int64_t bufsize = 100; \ | |||
| self->error_msg = (char *)malloc(bufsize); \ | |||
| self->error_msg = malloc(bufsize); \ | |||
There was a problem hiding this comment.
This is by design to keep all of the slashes right aligned
|
There are no warnings now because the casts would suppress them, but this fixes a bug when the number of rows in a CSV file exceeds the size of a long long |
jreback
approved these changes
Nov 13, 2020
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these are visual clutter, some are actual bugs though in unlikely cases (see the format specifiers)
https://stackoverflow.com/questions/605845/do-i-cast-the-result-of-malloc