Skip to content

CI/TST: use https to avoid ResourceWarning in html tests #37786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

See #36467
(no idea if this would actually fix anything, just mimicking what @alimcmaster1 did in #36480)

Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorisvandenbossche
Copy link
Member Author

At least it passed once .. ;)

@jreback jreback added the IO HTML read_html, to_html, Styler.apply, Styler.applymap label Nov 13, 2020
@jorisvandenbossche
Copy link
Member Author

Also passed a second time, so let's merge to see what happens

@jorisvandenbossche jorisvandenbossche added the Testing pandas testing functions or related to the test suite label Nov 13, 2020
@jorisvandenbossche jorisvandenbossche merged commit 1f42d45 into pandas-dev:master Nov 13, 2020
@jorisvandenbossche jorisvandenbossche deleted the ci-test-html branch November 13, 2020 15:24
@jorisvandenbossche
Copy link
Member Author

@simonjayhawkins is this something that needs to be backported?

@simonjayhawkins
Copy link
Member

@simonjayhawkins is this something that needs to be backported?

the coverage build is failing on 1.1.x, #37309, so no need to backport for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO HTML read_html, to_html, Styler.apply, Styler.applymap Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants