REF: simplify Block.replace #37781
Merged
REF: simplify Block.replace #37781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Nov 12, 2020
| ser.replace("", "") # no exception | ||
| obj = frame_or_series(pd.array([1, 2, 3], dtype="Int64")) | ||
| result = obj.replace("", "") # no exception | ||
| # should not have changed dtype |
There was a problem hiding this comment.
in master we get back int64 instead of Int64
jreback
added
Internals
|
I guess this technically a bug fix as previously replace on a Period would incorrectly cast, pls add a whatsnew, merge on green (or ping if you want). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff