Skip to content

TST: Isin converted floats unnecessarily to int causing rounding issues #37770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 29, 2020
Merged

TST: Isin converted floats unnecessarily to int causing rounding issues #37770

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
addfd75
[BUG]: Isin converted floats unnecessarily to int causing rounding is…
phofl Nov 11, 2020
63b1bc5
Run black
phofl Nov 11, 2020
f2273a3
Merge branch 'master' of https://github.com/pandas-dev/pandas into 19356
phofl Nov 11, 2020
1e4d572
Add issue number
phofl Nov 15, 2020
c0b1ab2
Merge branch 'master' of https://github.com/pandas-dev/pandas into 19356
phofl Nov 15, 2020
06aa378
Merge branch 'master' of https://github.com/pandas-dev/pandas into 19356
phofl Nov 26, 2020
d034421
Revert "[BUG]: Isin converted floats unnecessarily to int causing rou…
phofl Nov 26, 2020
c5b31ce
Revert "Revert "[BUG]: Isin converted floats unnecessarily to int cau…
phofl Nov 26, 2020
2d34b8f
Merge branch 'master' of https://github.com/pandas-dev/pandas into 19356
phofl Dec 5, 2020
b41b689
Remove unused import
phofl Dec 5, 2020
ef12c10
Remove whatsnew
phofl Dec 9, 2020
556cc52
Merge branch 'master' of https://github.com/pandas-dev/pandas into 19356
phofl Dec 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.2.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,6 +801,7 @@ Reshaping
- Bug in :func:`merge_ordered` returned wrong join result when length of ``left_by`` or ``right_by`` equals to the rows of ``left`` or ``right`` (:issue:`38166`)
- Bug in :func:`merge_ordered` didn't raise when elements in ``left_by`` or ``right_by`` not exist in ``left`` columns or ``right`` columns (:issue:`38167`)
- Bug in :func:`DataFrame.drop_duplicates` not validating bool dtype for ``ignore_index`` keyword (:issue:`38274`)
- Bug in :meth:`Series.isin` cast ``float`` unnecessarily to ``int`` when :class:`Series` to look in was from dtype ``int`` (:issue:`19356`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"cast float unnecessarily" -> "unnecessarily casting float dtypes"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably needs to move to 1.3.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense removing the whatsnew entirely, since your fix went into 1.2. Would be confusing having this in 1.3


Sparse
^^^^^^
Expand Down
8 changes: 8 additions & 0 deletions pandas/tests/series/methods/test_isin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,14 @@ def test_isin_period_freq_mismatch(self):
res = pd.core.algorithms.isin(ser, other)
tm.assert_numpy_array_equal(res, expected)

@pytest.mark.parametrize("values", [[-9.0, 0.0], [-9, 0]])
def test_isin_float_in_int_series(self, values):
# GH#19356 GH#21804
ser = Series(values)
result = ser.isin([-9, -0.5])
expected = Series([True, False])
tm.assert_series_equal(result, expected)


@pytest.mark.slow
def test_isin_large_series_mixed_dtypes_and_nan():
Expand Down