-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: troubleshoot windows builds #37746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Any idea which set of tests are likely to cause memory issues? Maybe matplotlib tests? |
hard to tell; in most cases there isnt a traceback pointing to a test |
new idea: lets just drop windows altogether |
@datapythonista help? ive been banging my head against this windows build and am getting nowhere, somehow managed to break a linux build for a little while there. Could we disable xdist and see if we can get more meaningful exception messages? Could we split this into multiple builds to avoid the time limit? |
@jbrockmendel how about one more rebase here and then let's merge and call it a day. |
just rebased, but i got a lot of failing builds before getting one to pass. lets try to get at least a few in a row before merging (and make sure we are OK with dropping all these optional dependencies) |
HOW DID THIS BREAK THE LINUX BUILDS |
broken elsewhere, pending patch for that. |
is that related to the something.xls and something.xlsx files that im seeing left behind after running the tests for the last day or two? |
damn, I was wondering where those came from. I will make a PR. edit: #37857 |
Is |
Sorry for the delay @jbrockmendel. I've been having a look, but I'm missing some context. The current failure seems to be a timeout. There is something I don't quite understand on it, seems like after finishing the tests, which take around 30 minutes, another call to pytest starts, and it doesn't finish on time. But this seems unrelated to the out of memory problems you mention. Does this make sense? Is the problem I'm seeing the one you're having trying to address? |
trying nth time, if green let's just merge |
wow 2 in a row, merging. |
@jbrockmendel i thought we had an issue about troubleshooting these builds, can you update it to say now windows/plotting excluded. |
Windows builds are still hitting what look like OOM errors. Trying splitting these into smaller pieces; its fragile.