Skip to content

CI: troubleshoot windows builds #37746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Nov 18, 2020
Merged

Conversation

jbrockmendel
Copy link
Member

Windows builds are still hitting what look like OOM errors. Trying splitting these into smaller pieces; its fragile.

@WillAyd
Copy link
Member

WillAyd commented Nov 10, 2020

Any idea which set of tests are likely to cause memory issues? Maybe matplotlib tests?

@WillAyd WillAyd added CI Continuous Integration Windows Windows OS labels Nov 10, 2020
@jbrockmendel
Copy link
Member Author

Any idea which set of tests are likely to cause memory issues? Maybe matplotlib tests?

hard to tell; in most cases there isnt a traceback pointing to a test

@jreback jreback added this to the 1.2 milestone Nov 11, 2020
@jbrockmendel
Copy link
Member Author

new idea: lets just drop windows altogether

@jbrockmendel
Copy link
Member Author

@datapythonista help? ive been banging my head against this windows build and am getting nowhere, somehow managed to break a linux build for a little while there.

Could we disable xdist and see if we can get more meaningful exception messages?

Could we split this into multiple builds to avoid the time limit?

@jreback
Copy link
Contributor

jreback commented Nov 14, 2020

@jbrockmendel how about one more rebase here and then let's merge and call it a day.

@jbrockmendel
Copy link
Member Author

how about one more rebase here and then let's merge and call it a day.

just rebased, but i got a lot of failing builds before getting one to pass. lets try to get at least a few in a row before merging (and make sure we are OK with dropping all these optional dependencies)

@jbrockmendel
Copy link
Member Author

HOW DID THIS BREAK THE LINUX BUILDS

@jreback
Copy link
Contributor

jreback commented Nov 14, 2020

HOW DID THIS BREAK THE LINUX BUILDS

broken elsewhere, pending patch for that.

@jbrockmendel
Copy link
Member Author

broken elsewhere, pending patch for that.

is that related to the something.xls and something.xlsx files that im seeing left behind after running the tests for the last day or two?

@twoertwein
Copy link
Member

twoertwein commented Nov 15, 2020

is that related to the something.xls and something.xlsx files that im seeing left behind after running the tests for the last day or

damn, I was wondering where those came from. ExcelWriter now opens the files which changed the behavior of this test pandas/tests/io/excel/test_writers.py:test_register_writer. This test wasn't expecting that an empty file will be created so it also didn't clean them up.

I will make a PR.

edit: #37857

@jbrockmendel
Copy link
Member Author

Is xvfb-run: error: Xvfb failed to start showing in the linux builds for any other PR? bc if not, then this is somehow breaking those builds.

@datapythonista
Copy link
Member

Sorry for the delay @jbrockmendel. I've been having a look, but I'm missing some context.

The current failure seems to be a timeout. There is something I don't quite understand on it, seems like after finishing the tests, which take around 30 minutes, another call to pytest starts, and it doesn't finish on time. But this seems unrelated to the out of memory problems you mention.

Does this make sense? Is the problem I'm seeing the one you're having trying to address?

@jreback jreback closed this Nov 18, 2020
@jreback jreback reopened this Nov 18, 2020
@jreback
Copy link
Contributor

jreback commented Nov 18, 2020

trying nth time, if green let's just merge

@jreback
Copy link
Contributor

jreback commented Nov 18, 2020

wow 2 in a row, merging.

@jreback jreback merged commit 446be82 into pandas-dev:master Nov 18, 2020
@jreback
Copy link
Contributor

jreback commented Nov 18, 2020

@jbrockmendel i thought we had an issue about troubleshooting these builds, can you update it to say now windows/plotting excluded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Windows Windows OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants