TYP: fix mypy ignored error in pandas/io/formats/latex.py #37738
Conversation
ivanovmg
changed the title
pandas/io/formats/latex.py
Outdated
| self.strcols: Sequence[Sequence[str]] = self._get_strcols() | ||
| self.strrows: Sequence[Sequence[str]] = list(zip(*self.strcols)) |
There was a problem hiding this comment.
The variable type annotations can be removed. My preference is not to add variable types annotations unless absolutely necessary.
the variable types for self.strcols and self.strrows can (should) be inferred from the rhs expression.
self.strcols: Revealed type is 'builtins.list[builtins.list[builtins.str]]'
self.strrows: Revealed type is 'builtins.list[builtins.tuple*[Any]]'
I'm not sure why mypy can't infer more precise for self.strrows
mypy is green, but if wanted to be more precise for self.strrows could use List[Tuple[str, ...]]
There was a problem hiding this comment.
Thank you for the suggestions!
Updated accordingly.
|
@simonjayhawkins looks like green (internal Windows py38_np18 error) |
|
Thanks @ivanovmg |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffHandle mypy ignored error in
pandas/io/formats/latex.py.