Skip to content

TST: parametrize in tests/plotting/test_frame.py #37735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 10, 2020
Merged

TST: parametrize in tests/plotting/test_frame.py #37735

merged 6 commits into from
Nov 10, 2020

Conversation

ivanovmg
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Parametrize some tests in pandas/tests/plotting/test_frame.py.

@charlesdong1991
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

charlesdong1991
charlesdong1991 approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@charlesdong1991 charlesdong1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

it seems two jobs just got stuck, i rerun it and hopefully ci jobs can be finished this time.

@charlesdong1991 charlesdong1991 added Testing pandas testing functions or related to the test suite Visualization plotting labels Nov 10, 2020
@charlesdong1991 charlesdong1991 added this to the 1.2 milestone Nov 10, 2020
@jreback jreback merged commit 365d843 into pandas-dev:master Nov 10, 2020
@jreback
Copy link
Contributor

jreback commented Nov 10, 2020

very nice!

@jreback
Copy link
Contributor

jreback commented Nov 24, 2020

@ivanovmg if you wouldn't mind can you mark most of these parameterized tests as slow. we are timing out are builds pretty offten: https://travis-ci.org/github/pandas-dev/pandas/jobs/745534073

and its taking like 45min. i don't think in and of themselves these tests are slow, but they do take some time. the slow builds have more room these tests.

@ivanovmg
Copy link
Member Author

@ivanovmg if you wouldn't mind can you mark most of these parameterized tests as slow. we are timing out are builds pretty offten: https://travis-ci.org/github/pandas-dev/pandas/jobs/745534073

and its taking like 45min. i don't think in and of themselves these tests are slow, but they do take some time. the slow builds have more room these tests.

Sure, I will go through it and mark the slowish tests as slow.

@jreback
Copy link
Contributor

jreback commented Nov 25, 2020

@ivanovmg if you wouldn't mind can you mark most of these parameterized tests as slow. we are timing out are builds pretty offten: https://travis-ci.org/github/pandas-dev/pandas/jobs/745534073
and its taking like 45min. i don't think in and of themselves these tests are slow, but they do take some time. the slow builds have more room these tests.

Sure, I will go through it and mark the slowish tests as slow.

great. likley let's mark most / all of them. the fast builds are just taking too long and timing out.

@ivanovmg ivanovmg deleted the cleanup/test_frame branch November 26, 2020 03:57
@ivanovmg ivanovmg mentioned this pull request Nov 26, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesdong1991 charlesdong1991 charlesdong1991 approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Visualization plotting
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanovmg @charlesdong1991 @jreback