TST: Add test for filling new rows through reindexing MultiIndex #37726
Conversation
phofl
added
MultiIndex
Needs Tests
|
|
||
| def test_reindex_fill_added_rows(): | ||
| # GH: 23693 | ||
| i = pd.MultiIndex.from_tuples([("a", "b"), ("d", "e")]) |
There was a problem hiding this comment.
can you use MultiIndex with out the "pd"
There was a problem hiding this comment.
and pls avoid 1-letter variable names. mi is a good choice for MultiIndex obj
| df = pd.DataFrame([[0, 7], [3, 4]], index=i, columns=["x", "y"]) | ||
| i2 = pd.MultiIndex.from_tuples([("a", "b"), ("d", "e"), ("h", "i")]) | ||
| result = df.reindex(i2, axis=0, method="ffill") | ||
| expected = pd.DataFrame([[0, 7], [3, 4], [3, 4]], index=i2, columns=["x", "y"]) |
There was a problem hiding this comment.
if the method being tested is DataFrame.reindex, then this belongs in tests.frame.method.test_reindex
There was a problem hiding this comment.
Sorry, was checking frame/indexing and could not find a reindex file. Moved the test now to the methods folder
| @@ -864,3 +864,12 @@ def test_reindex_signature(self): | |||
| "fill_value", | |||
| "tolerance", | |||
| } | |||
|
|
|||
| def test_reindex_fill_added_rows(self): | |||
There was a problem hiding this comment.
can you add "multiindex" in the name somehow, and "fill" -> "ffill"
half-sentence after the GH ref below on what the original problem was?
and total nitpick exclusively if you want to do me a kindness: I like the pattern # GH#23693 for the GH references
|
thanks @phofl |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffIssue was fixed previously