Skip to content

REF: remove Categorical._validate_listlike, unbox_listlike #37724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 10, 2020

Conversation

jbrockmendel
Copy link
Member

Getting closer to having these standardized.

jbrockmendel and others added 15 commits November 5, 2020 07:16
"columns(s)" sounded odd, I believe it was supposed to be just "column(s)".
@jreback jreback added the Categorical Categorical Data Type label Nov 10, 2020
@jreback jreback added this to the 1.2 milestone Nov 10, 2020
@jreback jreback added the Refactor Internal refactoring of code label Nov 10, 2020
@jreback
Copy link
Contributor

jreback commented Nov 10, 2020

assuming this is perf neutral.

@jbrockmendel
Copy link
Member Author

assuming this is perf neutral.

very slight improvement in reshape.merge from doing is_foo_dtype(x.dtype) instead of is_foo_dtype(x), other than that totally neutral.

@jreback jreback merged commit e534b10 into pandas-dev:master Nov 10, 2020
@jbrockmendel jbrockmendel deleted the cat-listlike-2 branch November 10, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants