Skip to content

TST: Add test for KeyError with MultiIndex #37719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 10, 2020
Merged

TST: Add test for KeyError with MultiIndex #37719

merged 4 commits into from
Nov 10, 2020

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 9, 2020

cc @jreback Added a test

@pep8speaks
Copy link

pep8speaks commented Nov 9, 2020 •
edited
Loading

Hello @phofl! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-09 21:43:16 UTC

@phofl phofl added Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex Needs Tests Unit test(s) needed to prevent regressions labels Nov 9, 2020
@jreback jreback added this to the 1.2 milestone Nov 9, 2020
@jreback
Copy link
Contributor

jreback commented Nov 9, 2020

can you merge master

@phofl
Merge branch 'master' of https://github.com/pandas-dev/pandas into 25236
5d2c8c1 
� Conflicts:
�	pandas/tests/indexing/multiindex/test_loc.py
@phofl
Copy link
Member Author

phofl commented Nov 9, 2020

Done

@jreback jreback merged commit 80749af into pandas-dev:master Nov 10, 2020
@jreback
Copy link
Contributor

jreback commented Nov 10, 2020

thanks @phofl

@phofl phofl deleted the 25236 branch November 10, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex Needs Tests Unit test(s) needed to prevent regressions
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

BUG: .loc indexing into MultiIndex with tuple with non-found keys gives wrong error
3 participants
@phofl @pep8speaks @jreback