Skip to content

TST: improve readability using dedent in test_to_string.py #37718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2020
Merged

TST: improve readability using dedent in test_to_string.py #37718

merged 1 commit into from
Nov 9, 2020

Conversation

ivanovmg
Copy link
Member

@ivanovmg ivanovmg commented Nov 9, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Improve readability of expected outputs using dedent in pandas/tests/io/formats/test_to_string.py

@simonjayhawkins simonjayhawkins added Clean Testing pandas testing functions or related to the test suite labels Nov 9, 2020
@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Nov 9, 2020
simonjayhawkins
simonjayhawkins approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ivanovmg lgtm pending green

@ivanovmg
Copy link
Member Author

ivanovmg commented Nov 9, 2020

One travis job failed because of its internal error. Can you re-start?
Windows py38_np18 error seems irrelevant.

@ivanovmg ivanovmg requested a review from dsaxton November 9, 2020 17:37
dsaxton
dsaxton approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@dsaxton dsaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jreback jreback merged commit d8f2f7d into pandas-dev:master Nov 9, 2020
@jreback
Copy link
Contributor

jreback commented Nov 9, 2020

thanks @ivanovmg keep em coming

@phofl phofl mentioned this pull request Nov 10, 2020
Closed
2 tasks
@ivanovmg ivanovmg deleted the cleanup/test-string branch November 10, 2020 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsaxton dsaxton dsaxton approved these changes

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@ivanovmg @jreback @dsaxton @simonjayhawkins