TST: move and reformat latex_na_rep test #37717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsaxton
approved these changes
Nov 9, 2020
| columns=["Group", "Data"], | ||
| ) | ||
| result = df.to_latex(na_rep=na_rep, float_format="{:.2f}".format) | ||
| expected = _dedent( |
There was a problem hiding this comment.
Nice. I think this same pattern appears in other places, could push this definition higher up and use elsewhere?
There was a problem hiding this comment.
Do you mean _dedent (without the preceding newline?)
There was a problem hiding this comment.
Ah, maybe the other cases aren't using the preceding newline so could probably use dedent alone for those
There was a problem hiding this comment.
Here I used custom _dedent only to make it compatible with raw strings.
In general I would simply use this
dedent(
"""\
content
"""
)
I guess that raw strings are mostly present here, in latex-related tests, because of the number of backslashes.
In other places we may want to use just built-in dedent
jreback
added
IO LaTeX
|
thanks @ivanovmg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffMove test to a more suitable location (
class TestToLatexFormatters)and reformat using
_dedentand raw string for better readability.